-
Notifications
You must be signed in to change notification settings - Fork 409
Fix/peoplepicker external docs #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmaillot
wants to merge
72
commits into
master
Choose a base branch
from
fix/peoplepicker-external-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as non-required component properties. Renamed MAX_ROW_HEIGHT to MAX_WIDTH.
Add the option to pass an URL of the site.
…es for improved theme handling and styling consistency
Without the import @pnp/sp/files the methid _getFiles will fail as web.getFolderByServerRelativePath(folderRelativeUrl).files will be undefined and therfore the next .select will fail. adding the import fixed the issue
…ders-incorrectly Fix issue with RichText toolbar not rendering correctly
…olumn-as-columnInternalName-not-working Fix missing closing tag in CAML OrderBy query for calculated columns. Closes #1870
Fix timezone issue in Calendar month view. Closes #2025
…aracters-issue Fix special characters encoding in ListItemComments. Closes #2047
Update FolderExplorerService.ts to add import @pnp/sp/files
FluentProvider to SelectFromSharePoint component so token is not undefined
Modified SPService methods (addAttachment and deleteAttachment) to return the updated item with new ETag. Added onAttachmentChange callback prop to ListItemAttachments and UploadAttachment components. Components now notify parent components when attachments are modified so ETag can be updated. Co-authored-by: AJIXuMuK <[email protected]>
Added public updateETag method to DynamicForm to allow external updates when list item is modified. Updated documentation for both ListItemAttachments and DynamicForm with integration examples. This completes the fix for ETag conflict errors when using attachments with DynamicForm. Co-authored-by: AJIXuMuK <[email protected]>
…ct icon names Co-authored-by: AJIXuMuK <[email protected]>
Fix: Replace missing indent icon names in RichText control
Fix ETag conflict errors when using ListItemAttachments with DynamicForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Provides clarity regarding external users search feature for the
PeoplePickercontrol.