-
Notifications
You must be signed in to change notification settings - Fork 390
Fix systematic spelling error: "Priviledged" → "Privileged" in PIM cmdlets #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ntation Co-authored-by: KoenZomers <[email protected]>
…ible→eligible Co-authored-by: KoenZomers <[email protected]>
Co-authored-by: KoenZomers <[email protected]>
|
@copilot Please ensure that you add an Alias attribute above the class with the old cmdlet name if you decide to change the class name to make it backwards compatible. You can see an example of this in the GetAzureADAppSitePermission.cs file. |
…mdlet names Co-authored-by: KoenZomers <[email protected]>
Added Alias attributes to all three cmdlets to maintain backward compatibility with the old misspelled cmdlet names. Users can continue using the old names while we encourage adoption of the correctly spelled versions. (commit cc2b8ff) |
|
@copilot Can you also rename the documentation files you have modified to have the typo be taken out of those? |
The documentation files were already renamed in commit 92d5f85. The three files were renamed from:
All content within these files has also been updated to use the correct spelling throughout. |
|
@copilot When creating a PR to propose a code change, please include adding an entry to the Changelog.md file under the [Current nightly] section picking either subcategory as feels appropriate for the change at hand: Added, Changed, Fixed, Removed. Ensure it contains a link to the PR. |
Co-authored-by: KoenZomers <[email protected]>
Added an entry to CHANGELOG.md under [Current nightly] - Fixed section documenting the spelling error corrections for the Privileged Identity Management cmdlets and noting that backward compatibility is maintained via aliases. (commit 0a8cc4e) |
|
@copilot To the changelog entry you've just added, please add a link to this PR behind it, as is the case with most other items in the changelog |
I don't have access to the PR number since it's still being created. Could you provide the PR number so I can add the link in the format |
Its 5119 |
Co-authored-by: KoenZomers <[email protected]>
Fix systematic typo: "Priviledged" → "Privileged" in PIM cmdlets
This PR addresses spelling errors throughout the codebase in all Privileged Identity Management (PIM) related functionality.
Changes Made:
PriviledgedIdentityManagement→PrivilegedIdentityManagementexpiratonHours→expirationHoursparameter nameelibible→eligibleBuild Status:
✅ Build successful with 0 warnings and 0 errors
Summary:
Backward Compatibility:
✅ The old misspelled cmdlet names are now maintained as aliases:
Get-PnPPriviledgedIdentityManagementRole(alias) →Get-PnPPrivilegedIdentityManagementRole(primary)Get-PnPPriviledgedIdentityManagementEligibleAssignment(alias) →Get-PnPPrivilegedIdentityManagementEligibleAssignment(primary)Enable-PnPPriviledgedIdentityManagement(alias) →Enable-PnPPrivilegedIdentityManagement(primary)Users can continue using the old cmdlet names, but the correct spelling is recommended.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.