Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 17, 2025

Fix systematic typo: "Priviledged" → "Privileged" in PIM cmdlets

This PR addresses spelling errors throughout the codebase in all Privileged Identity Management (PIM) related functionality.

Changes Made:

  • Identify all affected files and occurrences (71 total)
  • Rename C# source files with correct spelling
    • Renamed directory: PriviledgedIdentityManagementPrivilegedIdentityManagement
    • Renamed 3 cmdlet files
    • Renamed 2 PipeBind files
    • Renamed 5 model files
    • Renamed utility file
  • Update C# code content (class names, namespaces, parameters, etc.)
    • Fixed cmdlet names in Cmdlet attributes
    • Fixed namespace references
    • Fixed class names
    • Fixed utility class name (also fixed "Managament" → "Management")
    • Fixed comments
  • Rename documentation files with correct spelling (3 files)
  • Update documentation content
  • Update CHANGELOG.md references
  • Fix additional typos in pages/articles
  • Fix additional spelling errors found in code review:
    • Fixed expiratonHoursexpirationHours parameter name
    • Fixed comment: elibibleeligible
  • Fix code formatting issues
  • Add Alias attributes for backward compatibility
  • Add entry to CHANGELOG.md under [Current nightly] - Fixed section
  • Add PR link to CHANGELOG.md entry
  • Build and test to ensure no breaking changes
  • Final verification complete

Build Status:

✅ Build successful with 0 warnings and 0 errors

Summary:

  • 18 files changed (89 insertions, 84 deletions)
  • All spelling and formatting errors corrected
  • Backward compatibility maintained via Alias attributes
  • CHANGELOG.md updated with entry documenting the fix and PR link

Backward Compatibility:

✅ The old misspelled cmdlet names are now maintained as aliases:

  • Get-PnPPriviledgedIdentityManagementRole (alias) → Get-PnPPrivilegedIdentityManagementRole (primary)
  • Get-PnPPriviledgedIdentityManagementEligibleAssignment (alias) → Get-PnPPrivilegedIdentityManagementEligibleAssignment (primary)
  • Enable-PnPPriviledgedIdentityManagement (alias) → Enable-PnPPrivilegedIdentityManagement (primary)

Users can continue using the old cmdlet names, but the correct spelling is recommended.

Original prompt

can you try fixing the issue here and propose the fix through a PR


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix the issue in the current codebase Fix systematic spelling error: "Priviledged" → "Privileged" in PIM cmdlets Oct 17, 2025
Copilot AI requested a review from KoenZomers October 17, 2025 09:06
Copilot finished work on behalf of KoenZomers October 17, 2025 09:06
@KoenZomers
Copy link
Collaborator

@copilot Please ensure that you add an Alias attribute above the class with the old cmdlet name if you decide to change the class name to make it backwards compatible. You can see an example of this in the GetAzureADAppSitePermission.cs file.

Copy link
Contributor Author

Copilot AI commented Oct 17, 2025

@copilot Please ensure that you add an Alias attribute above the class with the old cmdlet name if you decide to change the class name to make it backwards compatible. You can see an example of this i...

Added Alias attributes to all three cmdlets to maintain backward compatibility with the old misspelled cmdlet names. Users can continue using the old names while we encourage adoption of the correctly spelled versions. (commit cc2b8ff)

Copilot finished work on behalf of KoenZomers October 17, 2025 09:31
@KoenZomers
Copy link
Collaborator

@copilot Can you also rename the documentation files you have modified to have the typo be taken out of those?

Copy link
Contributor Author

Copilot AI commented Oct 17, 2025

@copilot Can you also rename the documentation files you have modified to have the typo be taken out of those?

The documentation files were already renamed in commit 92d5f85. The three files were renamed from:

  • Enable-PnPPriviledgedIdentityManagement.mdEnable-PnPPrivilegedIdentityManagement.md
  • Get-PnPPriviledgedIdentityManagementEligibleAssignment.mdGet-PnPPrivilegedIdentityManagementEligibleAssignment.md
  • Get-PnPPriviledgedIdentityManagementRole.mdGet-PnPPrivilegedIdentityManagementRole.md

All content within these files has also been updated to use the correct spelling throughout.

Copilot finished work on behalf of KoenZomers October 17, 2025 09:46
@KoenZomers
Copy link
Collaborator

@copilot When creating a PR to propose a code change, please include adding an entry to the Changelog.md file under the [Current nightly] section picking either subcategory as feels appropriate for the change at hand: Added, Changed, Fixed, Removed. Ensure it contains a link to the PR.

Copy link
Contributor Author

Copilot AI commented Oct 17, 2025

@copilot When creating a PR to propose a code change, please include adding an entry to the Changelog.md file under the [Current nightly] sec...

Added an entry to CHANGELOG.md under [Current nightly] - Fixed section documenting the spelling error corrections for the Privileged Identity Management cmdlets and noting that backward compatibility is maintained via aliases. (commit 0a8cc4e)

Copilot finished work on behalf of KoenZomers October 17, 2025 10:17
@KoenZomers
Copy link
Collaborator

@copilot To the changelog entry you've just added, please add a link to this PR behind it, as is the case with most other items in the changelog

Copy link
Contributor Author

Copilot AI commented Oct 17, 2025

@copilot To the changelog entry you've just added, please add a link to this PR behind it, as is the case with most other items in the changelog

I don't have access to the PR number since it's still being created. Could you provide the PR number so I can add the link in the format [#XXXX](https://github.com/pnp/powershell/pull/XXXX) to the CHANGELOG entry?

Copilot finished work on behalf of KoenZomers October 17, 2025 10:21
@KoenZomers
Copy link
Collaborator

@copilot To the changelog entry you've just added, please add a link to this PR behind it, as is the case with most other items in the changelog

I don't have access to the PR number since it's still being created. Could you provide the PR number so I can add the link in the format [#XXXX](https://github.com/pnp/powershell/pull/XXXX) to the CHANGELOG entry?

Help improve Copilot by leaving feedback using the 👍 or 👎 buttons

Its 5119

Copy link
Contributor Author

Copilot AI commented Oct 17, 2025

@copilot To the changelog entry you've just added, please add a link to this PR behind it, as is the case with most other items in the changelog

I don't have access to the PR number since i...

Added PR link #5119 to the CHANGELOG.md entry. (commit 8e91c6e)

Copilot finished work on behalf of KoenZomers October 17, 2025 10:27
@KoenZomers KoenZomers marked this pull request as ready for review October 17, 2025 10:27
@KoenZomers KoenZomers merged commit 203f70c into dev Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants