Add Kurdish script support#154
Open
mr-baz wants to merge 3 commits into
Open
Conversation
Repository owner
deleted a comment from
meta-minion-001
May 19, 2026
Author
|
@pnarimani Could you please review my code? or what? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in
RTLTextMeshPro.csandRTLTextMeshPro3D.csbool farsifield with anAramaicScriptenum. This allows proper handling of Arabic, Persian, and Kurdish scripts, each with its own characteristics, and makes it easy to add support for additional languages in the future.ISerializationCallbackReceiverto handle existing components that used the oldfarsiboolean. InOnAfterDeserialize, iffarsiwas previously enabled, the enum is set toPersian; otherwise, it defaults toArabic.Changes in
RTLTextMeshProEditor.csandRTLTextMeshProEditor3D.csAramaicScriptenum instead of the oldfarsiboolean.ArabicGeneralLetters.csArabicIsolatedLettersConstantLetters.cs(new file)Most important changes in
GlyphFixer.csFix()method:a. Added an optional
checkSupportCharparameter. Most Kurdish fonts do not support the isolated Unicode forms of characters, so when an isolated form is required, the general Unicode form should be used instead. This parameter checks that support and is not needed for non-Kurdish scripts.b. In the first condition of the main loop, the Kurdish Lam character
ڵis now also checked. When detected,FixLamFormdetermines and applies the correct form based on the type of Lam used.c. In
TryGetKurdishException, the irregular cases for Kurdish Ha and Kurdish Ae (mentioned in point 5) are handled.d. In
CheckKurdishIsolateState, the function described in (a) is used.e. All remaining changes involve replacing the outdated
farsivariable with theAramaicScriptenum.Sample font
Fonts/Kurdifolder.Character range definition
KurdishAll.txtinside theRangefolder, containing all characters used in Kurdish-script fonts.