Upload BOM using the POST API #455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commons-logging pulled in by the Apache HttpClient used by Unirest does not support slf4j, which is used by Maven. Due to this you cannot easily enable HttpClient's debug logging.
When needed users can still use the PUT API to upload by setting the configuration flag `uploadWithPut`. Primary reason for switching to the POST API is because it plays nicer with WebApplication Firewalls in case of large request payloads. Note that the POST and PUT APIs have subtle differences in the request parameters. Further more, the BOM content is no longer kept in memory during upload, instead an InputStream is passed on to the different request handlers. This should also have a positive effect when processing huge SBOMs.
This results in the Content-Length being set in the request.
elmuerte
force-pushed
the
bugfix/454-post-sbom
branch
from
824c589 to
935abab
Compare
Contributor
Author
|
@pmckeown have you had the time to look at this PR yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #454
Changed BOM uploading to using the POST API by default. When needed users can still use the PUT API to upload by setting the
configuration flag
uploadWithPut. Primary reason for switching to the POST API is because it plays nicer with WebApplication Firewalls in case of large request payloads.Note that the POST and PUT APIs have subtle differences in the request parameters.
Further more, the BOM content is no longer kept in memory during upload, instead an InputStream is passed on to the different request handlers. This should also have a positive effect when processing huge SBOMs.
This took a little big more effort than I expected.