Skip to content

Spark-specific rounding #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pmattione-nvidia wants to merge 6 commits into
base: main_conversion_branch
Choose a base branch
from
Draft

Spark-specific rounding #2

pmattione-nvidia wants to merge 6 commits into from

Conversation

@pmattione-nvidia
Copy link
Owner

@pmattione-nvidia pmattione-nvidia commented Jul 9, 2024

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pmattione-nvidia pmattione-nvidia mentioned this pull request Jul 9, 2024
Open
@ttnghia ttnghia mentioned this pull request Jul 15, 2024
Closed
pmattione-nvidia pushed a commit that referenced this pull request Aug 4, 2025
@ttnghia
Remove stacktrace retrieval code (rapidsai#19048)
e692dfa 
As currently libcudf hides non-public symbols by default, stacktrace using C++ ABI `backtrace_symbols` no longer produces meaningful output. For example:
```
#0: gtests/STREAM_REDUCTION_TEST() [0x5bb586]
#1: gtests/STREAM_REDUCTION_TEST() [0x6a742d]
#2: gtests/STREAM_REDUCTION_TEST() [0x68a04e]
...
rapidsai#8: /usr/lib64/libc.so.6 : __libc_start_main+0xe5
rapidsai#9: gtests/STREAM_REDUCTION_TEST() [0x53419e]

unknown file: Failure
C++ exception with description "cudf_identify_stream_usage found unexpected stream!" thrown in the test body.
```

This PR removes completely the stacktrace generation code.

Closes rapidsai#18831. Also closes rapidsai#16724.

Authors:
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: rapidsai#19048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

libcudf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmattione-nvidia