Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add TTL to create cluster flow cached state #1404

Merged
merged 2 commits into from
Mar 7, 2025
Merged

add TTL to create cluster flow cached state #1404

merged 2 commits into from
Mar 7, 2025

Conversation

jsladerman
Copy link
Contributor

also fixes some links to the marketing site

@jsladerman jsladerman added bug-fix This pull request fixes a bug frontend Changes related to the frontend labels Mar 6, 2025
@jsladerman jsladerman requested a review from a team March 6, 2025 19:05
@linear Linear
Copy link

linear bot commented Mar 6, 2025

PROD-3290 plural cloud create cluster flow is busted

michaeljguarino
michaeljguarino reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a separate item store the ttl information seems intrinsically brittle, it might be better if you just wrap the object perhaps and store it under the same key.

@jsladerman jsladerman merged commit 42450f1 into master Mar 7, 2025
10 checks passed
@jsladerman jsladerman deleted the jake/prod-3290-plural-cloud-create-cluster-flow-is-busted branch March 7, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
bug-fix This pull request fixes a bug frontend Changes related to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsladerman @michaeljguarino