Skip to content

Fix for Missing Dropdown Options #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 3 commits into from
Dec 17, 2024
Merged

Fix for Missing Dropdown Options #448

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
034c880
Fix for missing dropdown options
PlaneNuts Dec 16, 2024
5b6f709
Update changelog
PlaneNuts Dec 16, 2024
7310ad7
Update inc/commoninjectionlib.class.php
PlaneNuts Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

- Fix default entity insertion for a user
- Fixed `SQL` error when creating new injection model
- Fixed issue with missing dropdown options

## [2.14.0] - 2024-10-10

Expand Down
7 changes: 7 additions & 0 deletions inc/commoninjectionlib.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,6 +2175,13 @@ public static function addToSearchOptions(
$type_searchOptions[$id]['injectable'] = self::FIELD_INJECTABLE;
}

//Some injection.class files are missing dropdown options. Set displaytype as dropdown if datatype is dropdown
//$tmp['displaytype'] is still empty. Set to prevent overwriting on next IF
if (isset($tmp['datatype']) && $tmp['datatype'] == 'dropdown') {
$type_searchOptions[$id]['displaytype'] = 'dropdown';
$tmp['displaytype'] = 'dropdown';
}

if (isset($tmp['linkfield']) && !isset($tmp['displaytype'])) {
$type_searchOptions[$id]['displaytype'] = 'text';
}
Expand Down
Loading