call backend methods directly instead of call_user_func #333
+31
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All backends implement this method and it is called unconditionally, so let's move it to the interface. The returned value is always parsed to integer, so we can unify the return type, too.
We expect all backend methods to implement certain logic. Now we have an interface to enforce this. Eliminate the use of call_user_func() and call backend methods directly.
stklcode
force-pushed
the
refactor/call_user_func
branch
from
f609481 to
bb0b939
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect all backend methods to implement certain logic. Now we have an interface
Cachify_Backendto enforce this. Eliminate the use ofcall_user_func()and call backend methods directly.