-
-
Couldn't load subscription status.
- Fork 1.9k
Fix legend container overflow #7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
attatrol
wants to merge
12
commits into
plotly:master
Choose a base branch
from
attatrol:fix-legend-container-overflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+196
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer. Need these for the case yref === 'container' && xref === 'paper'
archmoj
reviewed
Dec 16, 2024
|
@emilykl @camdecoster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes maximum height calculation for legends anchored to the container (
yref: "container"). Previously, legends would overflow outside the available container space. This fix ensures that when a legend is positioned relative to the container, its maximum height is constrained to the available space based on theyposition andyanchorsettings.Resolves #7072
Changes
computeLegendDimensionsfunction insrc/components/legend/draw.jsto calculate and constrainmaxheightwhenyref === 'container'legend_overflow_height.jsonto verify the bug fixDemo Video:
Before:
Screen.Recording.2025-10-27.at.11.30.24.PM.mov
After:
Screen.Recording.2025-10-27.at.11.30.52.PM.mov
Testing
npm startlegend_overflow_heightmock