Open
Conversation
added 2 commits
September 17, 2024 12:49
…ontainer. Need these for the case yref === 'container' && xref === 'paper'
archmoj
reviewed
Dec 16, 2024
Contributor
|
@emilykl @camdecoster |
emilykl
reviewed
Nov 11, 2025
emilykl
reviewed
Nov 11, 2025
emilykl
reviewed
Nov 11, 2025
emilykl
reviewed
Nov 12, 2025
src/components/legend/draw.js
Outdated
| } | ||
|
|
||
| // Set default maxheight if not provided by user | ||
| maxheight ||= (yref === 'paper' && !useFullLayoutHeight) ? 1 : 0.5; |
Contributor
There was a problem hiding this comment.
I'm pretty sure you could avoid the yref === 'paper' check here by just setting useFullLayoutHeight to false inside the else case
Contributor
There was a problem hiding this comment.
In fact I think you need to do that, because otherwise useFullLayoutHeight is undefined when yref is not 'paper'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes maximum height calculation for legends anchored to the container (
yref: "container"). Previously, legends would overflow outside the available container space. This fix ensures that when a legend is positioned relative to the container, its maximum height is constrained to the available space based on theyposition andyanchorsettings.Resolves #7072
Changes
computeLegendDimensionsfunction insrc/components/legend/draw.jsto calculate and constrainmaxheightwhenyref === 'container'Demo Video:
Code used for visual testing
Before:
Screen.Recording.2025-10-27.at.11.30.24.PM.mov
After:
Screen.Recording.2025-10-27.at.11.30.52.PM.mov
Testing
npm startlegend_overflow_heightmock