Skip to content

Add validation for session ticket format to prevent ValueError #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add validation for session ticket format to prevent ValueError #62

wants to merge 7 commits into from
+12 −1

Conversation

rohnsha0
Copy link
Member

fixes #33

@rohnsha0 rohnsha0 requested a review from davisagli May 25, 2025 11:54
@mister-roboto
Copy link

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@rohnsha0 rohnsha0 requested review from petschki, zopyx and gogobd May 25, 2025 11:55
davisagli
davisagli requested changes May 26, 2025
View reviewed changes
@rohnsha0
refactor: remove ticket validation logic from _validateTicket method …
4b2cd2d 
…and handle empty value in splitTicket function
@rohnsha0 rohnsha0 requested a review from davisagli May 28, 2025 04:16
@rohnsha0
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli
Copy link
Member

davisagli commented May 28, 2025 •
edited
Loading

@rohnsha0 Thanks! Could you add a test for this case?

@rohnsha0
Copy link
Member Author

@rohnsha0 Thanks! Could you add a test for this case?

PR incoming with tests! 😉

@rohnsha0
Copy link
Member Author

@davisagli I have added the tests

@rohnsha0
Copy link
Member Author

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petschki petschki Awaiting requested review from petschki

@zopyx zopyx Awaiting requested review from zopyx

@gogobd gogobd Awaiting requested review from gogobd

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module plone.session.tktauth, line 247, in splitTicket
3 participants
@rohnsha0 @mister-roboto @davisagli