Combo box: prevent races between async suggestions and options rewrite#6483
Open
aerosol wants to merge 6 commits into
Open
Combo box: prevent races between async suggestions and options rewrite#6483aerosol wants to merge 6 commits into
aerosol wants to merge 6 commits into
Conversation
aerosol
changed the title
aerosol
changed the title
apata
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses flaky combobox test mostly appearing in CI env.
The problem was essentially two async
suggest_funwere executed - on connect and on search. In tests, both sleep 500ms - which means they finish nearly simultaneously giving no guarantees aboutsend_updatemessage handling order. This change makes sure if search is in progress or made, the initial prefetch suggestions update will be ignored.Because we still have to support cases like messaging existing comboboxes to update their options (funnel step suggestions are shrinked via a broadcast, once one is picked) recognizing async function execution result is necessary.
To repro, revert the actual fix and run
mix test test/plausible_web/live/components/combo_box_test.exs --include slow --seed 1- should exceed 60s timeout.