Skip to content

Fix demo file paths #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix demo file paths #46

merged 1 commit into from
Jun 23, 2025

Conversation

Qard
Copy link
Member

@Qard Qard commented Jun 19, 2025

Fixes #45

@Qard Qard added the bug Something isn't working label Jun 19, 2025
@jlucaso1
Copy link
Contributor

jlucaso1 commented Jun 19, 2025

@Qard Im getting an different error:

➜  demo git:(fix-demo-file-paths) ✗ PHP_NODE_TEST=true node server.js
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
actual expected

'Hello, from PHP!'

    at Server.<anonymous> (file:///home/jlucaso/projects/php-node/demo/server.js:68:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '',
  expected: 'Hello, from PHP!',
  operator: 'strictEqual'
}

Node.js v24.2.0

Can be an linux only related issue?
Im on arch linux x64 (php.linux-x64-gnu.node)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Qard Qard merged commit 3362233 into main Jun 23, 2025
11 checks passed
@Qard Qard deleted the fix-demo-file-paths branch June 23, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run the demo in latest commits
3 participants