fix(api): expose conclusion provenance#847
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe public ChangesConclusion provenance in list responses
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Expose conclusion provenance through the public conclusions API by serializing existing
Documentfields on theConclusionresponse schema:Document.levelasconclusion_typeDocument.source_idsaspremisesThis lets API clients such as OpenConcho distinguish explicit, deductive, and inductive conclusions without coupling to Honcho's database schema or guessing missing types as explicit.
Fixes #846.
Root cause
The database already stores conclusion derivation metadata, but
/v3/workspaces/{workspace_id}/conclusions/listomitted that metadata from its response schema. Clients using the supported public API therefore could not render derived conclusion types accurately.Testing
Validated on the fork branch with:
Also deployed this patch in a self-hosted environment and verified the live OpenAPI schema exposes
conclusion_typeandpremises.Summary by CodeRabbit
New Features
Bug Fixes