refactor: Move CheckpointStore to Service Container #9
+21
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the container to register concrete CheckpointStores against an interface.
Reasoning
This achieves the same singleton idea as implemented with
static::store
inside of Checkpoint Model but gives us a more convenient place to put these classes. Binding to the container works really well here as we in fact have an interface and concrete classes that would implement it. The container will let us typehint the store in any needed location and withsingleton
we can maintain a unique instance for the whole request lifecycle.Testing
As a refactor, this change should maintain compatibility and keep all existing tests green