refactor: move local scopes to custom query builders #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the previous revision
fix: newest subquery failing in sqlite + improve its execution plan
|
Converting to draft until I can get back to this and resolve the failing tests |
register models in / use models from container
…etExcludedRelations()
…or in HasRevisions using it will only generate 1 query
fix: revisionable_id on null
…inst an interface
a-drew
force-pushed
the
move-local-scopes-to-custom-query-builders
branch
from
7833f1e to
f17afda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the sake of better static analysis (not sure there's much of a change for me) and cleaner / simpler models, this PR proposes to move local scopes seen in revision / checkpoint into their own query builder objects.
I've also expanded on the available scopes for revisions. Broken down bigger chunks into small scopes and even moved over the whereIn query from the global scope to the builder. This will make it easier to override specific constraints used to fetch revisions closest to a moment as well as re-use the same scopes for fetching latest content inside of a timeline.
Testing
While this is a refactor, it does move some key methods that would be customized when implementing this package so there could be broken changes. Otherwise, this is ready when both psalm and existing tests are 🟢