Fix invalid gtfs file caused by agencies not in hardcoded list #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusnorton
reviewed
Aug 5, 2024
The timetable can contain routes not in the hardcoded list in agencies.ts. In particular I've seen QH, QR, QU, and QV in the national rail data portal timetable. This commit exports such routes using the existing 'ZZ' - Other operator agency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputting a timetable from the national rail data portal I get an error when importing into OpenTransitPlanner:
could not find Agency with specified id=QV for route <Route null null>I believe OpenTransitPlanner is correct here because the GTFS validator agress the file is invalid.
The routes.txt contains routes with agency id QH, QR, QU, and QV. Per openraildata these are network rail business codes for Anglia, North West & Central, Wales & Western, and East Midlands. One example is the "QR boat service from STQ to STQ". This appears to be the ferry from Southampton to the Isle of Wight operated by South Western. I have no idea why it isn't under their code.
At least in this specific table all the routes are by bus or boat.
The simplest solution I can think of would be to omit the operator code for operators not in the hardcoded agencies list. That way they will be exported with the existing 'ZZ' - Other operator code.