feat(routing): added base ab_routing schemas and unit tests #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majkshkurti
reviewed
Oct 29, 2025
packages/python/goatlib/src/goatlib/routing/schemas/ab_routing.py
Outdated
Show resolved
Hide resolved
packages/python/goatlib/src/goatlib/routing/schemas/ab_routing.py
Outdated
Show resolved
Hide resolved
Comment on lines
19
to
52
| @pytest.fixture | ||
| def valid_location_data() -> Dict[str, float]: | ||
| """Provides valid data for a Location model.""" | ||
| return {"lat": 48.8566, "long": 2.3522} | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def valid_leg_data(valid_location_data: Dict[str, float]) -> Dict[str, Any]: | ||
| """Provides a valid dictionary for creating an ABRouteLeg.""" | ||
| now = datetime.now(timezone.utc) | ||
| return { | ||
| "leg_id": "leg_123", | ||
| "mode": TransportMode.WALK, | ||
| "origin": valid_location_data, | ||
| "destination": {"lat": 48.8606, "long": 2.3376}, | ||
| "departure_time": now, | ||
| "arrival_time": now, | ||
| "duration": 300, | ||
| "distance": 500, | ||
| } | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def valid_route_data(valid_leg_data: Dict[str, Any]) -> Dict[str, Any]: | ||
| """Provides a valid dictionary for creating an ABRoute.""" | ||
| return { | ||
| "route_id": "route_abc", | ||
| "duration": 25, # Inherited from base Route | ||
| "distance": 1500, # Inherited from base Route | ||
| "time": datetime.now(timezone.utc), # Inherited from base Route | ||
| "legs": [valid_leg_data], | ||
| "optimization_score": 0.9, | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it would better to test the response with some real data that motis returns. Maybe we can dump it in a json inside the data folder
There was a problem hiding this comment.
True, I am currently working on creating the json files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added base ab_routing schemas and unit tests in the packages folder.
TODOs are related to default values and time fixtures that can be decided later.