test(e2e): keep isolated server alive across agent execs - #379
Open
pkyosx wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T-45 makes the isolated e2e station survive independent agent execs with an explicit, observable lifecycle carrier, and makes the unsupported member browser route fail clearly.
The root-cause evidence is a paired experiment run on the same machine and in the same launch exec: the ordinary
nohupserver on:8791disappeared before the next independent exec (curlrc=7, PID gone), while the tmux server on:8793returned real/api/versionJSON and remained alive. This conclusion is deliberately limited to the observed Codex runtime; the exact killer/signal was not isolated, and the change does not claim tmux identifies that killer.Changes
oc-e2e-*tmux socket/session and persist its exact identity.:7755.tmuxin the macOSmacos-e2ejob before setup; the guard suite checks that this CI prerequisite remains wired beforerun_all.sh.OC_E2E_BROWSER_BACKEND=cmuxis rejected before setup with a named message, with README/CLAUDE guidance.Validation
origin/main=4b4044109924896ac1653f425254294bdc018718; current PR head is8d462353333fd02ad27a86e4c43771102a5b909c.bash e2e_test/tests_guard/run.shreturned rc=0 withPASS=319 FAIL=0and[tests_guard] all green; this includes the exact-call mutant and the CI tmux prerequisite guard.git_sha=453a6401; the newtests/19_user_operation_contracts.spec.jsran in an independent exec with3 passed (3.1s); exact teardown returned rc=0, released:8791, and left production:7755untouched.git ls-remoteand GitHub API matched the PR head above; PR base readback is the rebased4b404410.33466521887on the prior head exposed the missing macOStmuxprerequisite:macos-e2efailed before setup could create anything. That was fixed in8d462353; replacement CI run33467596629is the authoritative rerun for this head and completedsuccess.macos-e2e,frontend-ct,frontend-checks,go-checks,hygiene,e2e-isolation-guard,bin-guards,tcc-anchor,contract-guards,drift-checks,conformance) and the two conditional jobs (auto-beta,notify-main-red) were explicitlyskipped; every returned job/checkhead_shadeduplicates to exactly8d462353333fd02ad27a86e4c43771102a5b909c.243f90fc; a current-head follow-up review is requested after this rebase.Known limits
bin/ci.shrun, parallel execution, or load test was performed; the single new contract spec above was run as the targeted post-rebase check.Do not merge from this worker; final CI/accounting and land remain with Kyle.