Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for optimization #246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+24 −74
Open

Fix for optimization #246

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbeb80d
Optimize Access Control
mtfum Jan 24, 2019
e04a4a1
Remove unnecessary class 'WindowRootViewController' and rename filena…
mtfum Jan 24, 2019
b3a6723
Add final for internal classes
mtfum Apr 11, 2019
455bfc9
Rename ContainerView to Window
mtfum Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary class 'WindowRootViewController' and rename filena… 
…me 'Window' to 'ContainerView'
@mtfum
mtfum committed Apr 11, 2019
commit e04a4a17e40e86e9c35db0b90dbc36a600e72408
12 changes: 4 additions & 8 deletions PKHUD.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
@@ -30,8 +30,7 @@
F996324D19514FEF001F73CA /* PKHUDAssets.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324619514FEF001F73CA /* PKHUDAssets.swift */; };
F996324F19514FEF001F73CA /* PKHUD.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324819514FEF001F73CA /* PKHUD.swift */; };
F996325019514FEF001F73CA /* FrameView.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324919514FEF001F73CA /* FrameView.swift */; };
F996325219514FEF001F73CA /* Window.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324B19514FEF001F73CA /* Window.swift */; };
F996325319514FEF001F73CA /* WindowRootViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324C19514FEF001F73CA /* WindowRootViewController.swift */; };
F996325219514FEF001F73CA /* ContainerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996324B19514FEF001F73CA /* ContainerView.swift */; };
F996325519514FF3001F73CA /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = F996325419514FF3001F73CA /* Images.xcassets */; };
F996325919515052001F73CA /* DemoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = F996325819515052001F73CA /* DemoViewController.swift */; };
/* End PBXBuildFile section */
@@ -108,8 +107,7 @@
F996324619514FEF001F73CA /* PKHUDAssets.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PKHUDAssets.swift; sourceTree = "<group>"; };
F996324819514FEF001F73CA /* PKHUD.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PKHUD.swift; sourceTree = "<group>"; };
F996324919514FEF001F73CA /* FrameView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FrameView.swift; sourceTree = "<group>"; };
F996324B19514FEF001F73CA /* Window.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Window.swift; sourceTree = "<group>"; };
F996324C19514FEF001F73CA /* WindowRootViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = WindowRootViewController.swift; sourceTree = "<group>"; };
F996324B19514FEF001F73CA /* ContainerView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ContainerView.swift; sourceTree = "<group>"; };
F996325419514FF3001F73CA /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Images.xcassets; sourceTree = "<group>"; };
F996325819515052001F73CA /* DemoViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemoViewController.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */
@@ -244,8 +242,7 @@
isa = PBXGroup;
children = (
F996324919514FEF001F73CA /* FrameView.swift */,
F996324B19514FEF001F73CA /* Window.swift */,
F996324C19514FEF001F73CA /* WindowRootViewController.swift */,
F996324B19514FEF001F73CA /* ContainerView.swift */,
);
name = Internal;
sourceTree = "<group>";
@@ -439,13 +436,12 @@
640011571C5B6C080013F32B /* HUD.swift in Sources */,
3097AF3A1C4843AE007DD42B /* PKHUDRotatingImageView.swift in Sources */,
F935B1611B2B8C8E003C3734 /* PKHUDTextView.swift in Sources */,
F996325319514FEF001F73CA /* WindowRootViewController.swift in Sources */,
F908BEC31BB84D0B0015E5A8 /* PKHUDAnimating.swift in Sources */,
F908BEC81BB85EA70015E5A8 /* PKHUDProgressView.swift in Sources */,
F908BEC01BB849290015E5A8 /* PKHUDSuccessView.swift in Sources */,
F908BEC51BB852C60015E5A8 /* PKHUDErrorView.swift in Sources */,
F935B15D1B2B8C20003C3734 /* PKHUDSquareBaseView.swift in Sources */,
F996325219514FEF001F73CA /* Window.swift in Sources */,
F996325219514FEF001F73CA /* ContainerView.swift in Sources */,
F935B15F1B2B8C7E003C3734 /* PKHUDWideBaseView.swift in Sources */,
F996324D19514FEF001F73CA /* PKHUDAssets.swift in Sources */,
F996324F19514FEF001F73CA /* PKHUD.swift in Sources */,
6 changes: 3 additions & 3 deletions PKHUD/Window.swift → PKHUD/ContainerView.swift
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ internal class ContainerView: UIView {
commonInit()
}

fileprivate func commonInit() {
private func commonInit() {
backgroundColor = UIColor.clear
isHidden = true

@@ -52,7 +52,7 @@ internal class ContainerView: UIView {
isHidden = false
}

fileprivate var willHide = false
private var willHide = false

internal func hideFrameView(animated anim: Bool, completion: ((Bool) -> Void)? = nil) {
let finalize: (_ finished: Bool) -> Void = { finished in
@@ -80,7 +80,7 @@ internal class ContainerView: UIView {
}
}

fileprivate let backgroundView: UIView = {
private let backgroundView: UIView = {
let view = UIView()
view.backgroundColor = UIColor(white: 0.0, alpha: 0.25)
view.alpha = 0.0
46 changes: 0 additions & 46 deletions PKHUD/WindowRootViewController.swift
View file

This file was deleted.