tests: replace deprecated given/when usage with if/elsif/else

pkgcraft · Dec 15, 2023 · a2bdefa · a2bdefa
1 parent aa8e118
commit a2bdefa
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 18 deletions.
diff --git a/t/Pkgcraft/Dep.t b/t/Pkgcraft/Dep.t
@@ -86,15 +86,13 @@ foreach my $str (@{$DEP_DATA->{"compares"}}) {
   my ($s1, $op, $s2) = split ' ', $str;
   my $d1 = Pkgcraft::Dep->new($s1);
   my $d2 = Pkgcraft::Dep->new($s2);
-  given ($op) {
-    when ("<") { ok($d1 < $d2, $str) }
-    when ("<=") { ok($d1 <= $d2, $str) }
-    when ("==") { ok($d1 == $d2, $str) }
-    when ("!=") { ok($d1 != $d2, $str) }
-    when (">=") { ok($d1 >= $d2, $str) }
-    when (">") { ok($d1 > $d2, $str) }
-    default { die "unknown operator: $op" }
-  }
+  if ($op eq "<") { ok($d1 < $d2, $str) }
+  elsif ($op eq "<=") { ok($d1 <= $d2, $str) }
+  elsif ($op eq "==") { ok($d1 == $d2, $str) }
+  elsif ($op eq "!=") { ok($d1 != $d2, $str) }
+  elsif ($op eq ">=") { ok($d1 >= $d2, $str) }
+  elsif ($op eq ">") { ok($d1 > $d2, $str) }
+  else { die "unknown operator: $op" }
 }
 
 # dep sorting

diff --git a/t/Pkgcraft/Version.t b/t/Pkgcraft/Version.t
@@ -42,15 +42,13 @@ foreach my $str (@{$VERSION_DATA->{"compares"}}) {
   my ($s1, $op, $s2) = split ' ', $str;
   my $v1 = Pkgcraft::Version->new($s1);
   my $v2 = Pkgcraft::Version->new($s2);
-  given ($op) {
-    when ("<") { ok($v1 < $v2, $str) }
-    when ("<=") { ok($v1 <= $v2, $str) }
-    when ("==") { ok($v1 == $v2, $str) }
-    when ("!=") { ok($v1 != $v2, $str) }
-    when (">=") { ok($v1 >= $v2, $str) }
-    when (">") { ok($v1 > $v2, $str) }
-    default { die "unknown operator: $op" }
-  }
+  if ($op eq "<") { ok($v1 < $v2, $str) }
+  elsif ($op eq "<=") { ok($v1 <= $v2, $str) }
+  elsif ($op eq "==") { ok($v1 == $v2, $str) }
+  elsif ($op eq "!=") { ok($v1 != $v2, $str) }
+  elsif ($op eq ">=") { ok($v1 >= $v2, $str) }
+  elsif ($op eq ">") { ok($v1 > $v2, $str) }
+  else { die "unknown operator: $op" }
 }
 
 # version sorting