Fix my ignoring of fadvise, make pthread operations have a safety che…

…ck to ensure that they are initialized prior to use, and make condattr "work" but cond_init fail if you use invalid ones.

include/alltypes.h.in

@@ -83,9 +83,9 @@ TYPEDEF unsigned socklen_t;
 TYPEDEF unsigned short sa_family_t;
 
 TYPEDEF struct { union { int __i[sizeof(long)==8?14:9]; volatile int __vi[sizeof(long)==8?14:9]; unsigned long __s[sizeof(long)==8?7:9]; } __u; } pthread_attr_t;
-TYPEDEF struct { int __i; void* __p } pthread_mutex_t;
+TYPEDEF struct { int __i; int __inited; void* __p } pthread_mutex_t;
 TYPEDEF struct { union { int __i[sizeof(long)==8?10:6]; volatile int __vi[sizeof(long)==8?10:6]; volatile void *volatile __p[sizeof(long)==8?5:6]; } __u; } mtx_t;
-TYPEDEF struct { int __i; void *__p; } pthread_cond_t;
+TYPEDEF struct { int __i; int __inited; void *__p; } pthread_cond_t;
 TYPEDEF struct { union { int __i[12]; volatile int __vi[12]; void *__p[12*sizeof(int)/sizeof(void*)]; } __u; } cnd_t;
 TYPEDEF struct { int __i; void *__p; } pthread_rwlock_t;
 TYPEDEF struct { union { int __i[sizeof(long)==8?8:5]; volatile int __vi[sizeof(long)==8?8:5]; void *__p[sizeof(long)==8?4:5]; } __u; } pthread_barrier_t;

src/fcntl/posix_fadvise.c

@@ -3,4 +3,5 @@
 
 int posix_fadvise(int fd, off_t base, off_t len, int advice)
 {
+    return 0;
 }

src/thread/pthread_cond_broadcast.c

@@ -2,6 +2,7 @@
 
 int pthread_cond_broadcast(pthread_cond_t *c)
 {
+    ZASSERT(c->__inited == 42);
     if (!c->__i)
         return 0;
     c->__i = 0;

src/thread/pthread_cond_destroy.c

@@ -2,5 +2,6 @@
 
 int pthread_cond_destroy(pthread_cond_t *c)
 {
+    ZASSERT(c->__inited == 42);
     return 0;
 }

src/thread/pthread_cond_init.c

@@ -3,7 +3,17 @@
 
 int pthread_cond_init(pthread_cond_t *restrict c, const pthread_condattr_t *restrict a)
 {
-    ZASSERT(!a);
+    if (a) {
+        clockid_t clock;
+        ZASSERT(!pthread_condattr_getclock(a, &clock));
+        if (clock != CLOCK_REALTIME)
+            return ENOSYS;
+        int pshared;
+        ZASSERT(!pthread_condattr_getpshared(a, &pshared));
+        if (pshared)
+            return ENOSYS;
+    }
     c->__i = 0;
+    c->__inited = 42;
     return 0;
 }

src/thread/pthread_cond_signal.c

@@ -9,6 +9,7 @@ static void callback(_Bool did_unpark_thread, _Bool may_have_more_threads, void*
 
 int pthread_cond_signal(pthread_cond_t *c)
 {
+    ZASSERT(c->__inited == 42);
     if (!c->__i)
         return 0;
     zunpark_one(&c->__i, callback, c);

src/thread/pthread_cond_timedwait.c

@@ -21,6 +21,7 @@ void before_sleep_callback(void* arg)
 
 int __pthread_cond_timedwait(pthread_cond_t *restrict c, pthread_mutex_t *restrict m, const struct timespec *restrict ts)
 {
+    ZASSERT(c->__inited == 42);
     wait_data data;
     data.c = c;
     data.m = m;

src/thread/pthread_mutex_destroy.c

@@ -3,5 +3,6 @@
 
 int pthread_mutex_destroy(pthread_mutex_t *mutex)
 {
+    ZASSERT(mutex->__inited == 42);
     return 0;
 }

src/thread/pthread_mutex_init.c

@@ -5,5 +5,6 @@ int pthread_mutex_init(pthread_mutex_t *restrict m, const pthread_mutexattr_t *r
 {
     ZASSERT(!a);
     m->__i = 0;
+    m->__inited = 42;
     return 0;
 }

src/thread/pthread_mutex_lock.c

@@ -3,6 +3,7 @@
 
 int __pthread_mutex_lock(pthread_mutex_t *m)
 {
+    ZASSERT(m->__inited == 42);
     volatile int* l = (volatile int*)&m->__i;
     LOCK(l);
     return 0;

src/thread/pthread_mutex_trylock.c

@@ -3,6 +3,7 @@
 
 int __pthread_mutex_trylock(pthread_mutex_t *m)
 {
+    ZASSERT(m->__inited == 42);
     volatile int* l = (volatile int*)&m->__i;
     TRYLOCK(l);
     return 0;

src/thread/pthread_mutex_unlock.c

@@ -3,6 +3,7 @@
 
 int __pthread_mutex_unlock(pthread_mutex_t *m)
 {
+    ZASSERT(m->__inited == 42);
     volatile int* l = (volatile int*)&m->__i;
     UNLOCK(l);
     return 0;