Bug: make atlas loader use absolute paths #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miltoncandelero please accept this PR! The library is not usable at current version without it! |
|
The problem was not absolute paths but paths with dots inside of them due to an upstream bug in pixi. This PR would have duplicated the leading slash in cases where the path didn't have the dot issue. This commit is a better workarround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are getting an issue, where if we use absolute paths for an atlas it tries to load textures from the incorrect url. I narrowed it down to it not loading textures using an absolute path.
There is some discussion about it in this thread, #493