Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding debug capabilities to every single spine! #453

Merged

Conversation

miltoncandelero
Copy link
Contributor

Based on the work of @sbfkcel (https://github.com/sbfkcel/pixi-spine-debug)

Totally integrated into SpineBase it should just work ™

Tested with umd builds. Examples are done but waiting for this to be reviewed 👍

image

@miltoncandelero
Copy link
Contributor Author

This now includes a new SpineDebugRenderer and ISpineDebugRenderer

This allows sharing a single debug settings object between all spines and also extending the debug renderer easily (for example, adding event names)

@Friksel
Copy link

Friksel commented Oct 13, 2022

Oh, just commented this in the other thread:

Thanks, good to see a continuation! Not sure if it's a good thing to have this in the official support tho; It's nice if it's officially supported, so all for that, but we want to keep our project output files as small as possible so please keep this seperated in a different module we can exclude from development builds!!

As it seems the debugger is now added to the existing code making the lib larger? If that's the case, I'm not for it because that would mean there's more output code than needed in production builds.

Is there any way to keep this seperated on production builds? So we can keep outputs as small as possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants