Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup peer dependencies #452

Merged

Conversation

miltoncandelero
Copy link
Contributor

  • Loader packages relied on @pixi/app and resource-loader which were not used.
  • Added @pixi/extensions to be compatible with 6.5.1
    • Added a peerDependenciesMeta to make @pixi/extensions optional since is not needed before 6.5.1

After an npm install gave me errors on my project that doesn't rely on app, I investigated and found that neither @pixi/app nor resource-loader were being used in the code.
I also added the optional new peerDep of @pixi/extensions to be compatible with @pixi/core version 6.5.1

- Loader packages relied on `@pixi/app` and `resource-loader` which were not used.
- Added `@pixi/extensions` to be compatible with 6.5.1
  - Added a `peerDependenciesMeta` to make `@pixi/extensions` optional since is not needed before 6.5.1
@miltoncandelero miltoncandelero marked this pull request as draft August 5, 2022 18:56
@miltoncandelero
Copy link
Contributor Author

After talking with @andrewstart we came to the conclusion that I shouldn't have the burden to track my dependencies' dependencies.

I will move @pixi/extensions to devDependencies

I will also check which peerDependencies are actually being used 🤔 just to be extra sure and tackle that chore

Interesting note about spine-base dependencies:
`"@pixi/runner": "^6.1.0",` ,`"@pixi/settings": "^6.1.0",` and `"@pixi/extensions": "^6.1.0"` are only needed to generate the typescript definition file so they were moved to devDependencies
@miltoncandelero
Copy link
Contributor Author

Interesting note about spine-base dependencies:
"@pixi/runner": "^6.1.0", ,"@pixi/settings": "^6.1.0", and "@pixi/extensions": "^6.1.0" are only needed to generate the typescript definition file so they were moved to devDependencies

@miltoncandelero miltoncandelero marked this pull request as ready for review August 5, 2022 20:01
@miltoncandelero
Copy link
Contributor Author

Goooot'em!

This latest commit ensures that we never forget any peerDep from our dependencies.

There is probably a better way of doing this, but this works 🤷


Now I think we are good to merge 👍
UMD Builds seem to be hash perfect compared to the previous one so I think everything is fine 😅

@ivanpopelyshev ivanpopelyshev merged commit 5077220 into pixijs-userland:master Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants