Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface integration #407

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

liamf1986
Copy link
Contributor

Attempted correct integration of types across the 3 supported apis.

Had to add the dependencies @pixi/runner and @pixi/settings to get the initial branch to build at all. Not sure why they were needed.

commit: initial-changes copies the initial wip-branch here: https://github.com/pixijs/spine/tree/wip-interfaces

@liamf1986
Copy link
Contributor Author

@ivanpopelyshev change feels quite large, hopefully this is along the lines of what you were thinking. It's building for me now though not sure why I needed to add those 2 new dependencies, might wanna test it yourself to be sure.

@ivanpopelyshev
Copy link
Collaborator

Yes, I'm going to check why do we need settings from pixi. pixi-spine has its own settings

@ivanpopelyshev ivanpopelyshev changed the base branch from master to wip-interfaces August 24, 2021 16:18
@ivanpopelyshev ivanpopelyshev changed the base branch from wip-interfaces to master August 24, 2021 16:19
@ivanpopelyshev ivanpopelyshev merged commit 54d7129 into pixijs-userland:master Aug 24, 2021
@ivanpopelyshev
Copy link
Collaborator

ivanpopelyshev commented Aug 24, 2021

Yes, found it, that's what rush update wants:


@pixi/[email protected] requires a peer of @pixi/[email protected] but none was installed.
@pixi/[email protected] requires a peer of @pixi/[email protected] but none was installed.
@pixi/[email protected] requires a peer of @pixi/[email protected] but none was installed.

I will resolve this problem later. I know that at least ticker can be removed from @pixi/core by embedding video-textures in different package

Please try 3.0.9! Dont look in binary files, they have headers 3.0.8, that's not true ;)

@liamf1986 liamf1986 deleted the wip-interfaces- branch August 26, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants