Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded types to add more missing properties #405

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

liamf1986
Copy link
Contributor

Expanded the types a little more to add some other properties I've found shared across Spine 3.7, 3.8 and 4.0.

I wouldn't normally include enums in the same file as interfaces but I couldn't identify a clear pattern for where to define them based on the rest of the code so I just put them at the top of this file. If you'd rather they were split into individual files or put into one enum file together just let me know.

Mostly new additions but there is the one fix where I accidentally typed tracks as ITrackEntry instead of ITrackEntry[] previously.

@ivanpopelyshev
Copy link
Collaborator

I use pixi blendModes directly, you can remove that enum in favor of import('@pixi/const').BLEND_MODES

@ivanpopelyshev ivanpopelyshev merged commit b025136 into pixijs-userland:master Aug 23, 2021
@liamf1986 liamf1986 deleted the expanded-types branch August 23, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants