Expanding types to closer match runtimes #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That one is good, do you want to do anything else or i can publish new version? |
Nothing else from me for now so publish away :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few holes in the Types while porting to v3 so I've added what I identified here.
ISkeletonI mimicked the Generic setup ofIBoneandISlotfor the newISkinfor consistency though I'm not sure if it is required.ISkinhas some extra properties in 3.8 and 4.0 but as they are not present in 3.7 I've just left them off for now keeping it simple.voidreturn types toaddListenerandremoveListenerfor consistency.