Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Es5 builds #397

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Es5 builds #397

merged 5 commits into from
Jul 27, 2021

Conversation

gprzybylowicz
Copy link
Contributor

No description provided.

@gprzybylowicz gprzybylowicz mentioned this pull request Jul 21, 2021
Open
@ivanpopelyshev
Copy link
Collaborator

Holy cow!

@gprzybylowicz
Copy link
Contributor Author

Yeah, I know it's quite a lot of changes :) Just to sum up here:

  1. I copied rollup config and added typescript instead of surcase
  2. Needed to turn off declaration in config by default cause rollup throws errors, same with lack of 'baseUrl'
  3. Declarations set to true in tsconfig-api.json
  4. New ver of rollup

@ivanpopelyshev
Copy link
Collaborator

Yes, i thought to do something like that.

OK, i'll check tomorrow :)

@gprzybylowicz
Copy link
Contributor Author

Hi @ivanpopelyshev Did you have chance to review PR?

@ivanpopelyshev ivanpopelyshev merged commit baf1249 into pixijs-userland:master Jul 27, 2021
@ivanpopelyshev
Copy link
Collaborator

done, please check it

@gprzybylowicz
Copy link
Contributor Author

thanks, works like a charm

@ivanpopelyshev ivanpopelyshev mentioned this pull request Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gprzybylowicz @ivanpopelyshev