Range can be turned into a lazy-seq #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1565,6 +1565,20 @@ For more information, see http://clojure.org/special_forms#binding-forms"} | |||
| val | |||
| nil)))) | |||
|
|
|||
| ;; TODO: place withing Range type when protocols support multi-arity functions | |||
There was a problem hiding this comment.
A nitpick: s/withing/within/.
Also, you could place it within Range and use range->seq as an inner function. Especially because -seq has arity 1.
thomasmulvaney
force-pushed
the
lazy-range
branch
from
8022e06 to
1a68e32
Compare
halgari
added a commit
that referenced
this pull request
Jan 8, 2015
Range can be turned into a lazy-seq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now go directly from a Range to a lazy sequence. I also switched the field declarations from keywords to symbols.