Add support for lower case headers in pagination #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the webserver only return lower case headers which leads to an error being thrown when the pagination tries to index the array with headers. This adds methods to fix this issue.
Nitpick-CI
reviewed
Nov 20, 2019
src/WoocommerceClient.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| public function getHeaderWithCase($header) { |
There was a problem hiding this comment.
Opening brace should be on a new line
Nitpick-CI
reviewed
Nov 20, 2019
| /** | ||
| * @test | ||
| */ | ||
| public function headers_are_converted_to_lower_case_when_requested() |
There was a problem hiding this comment.
Method name WoocommerceClientTest::headers_are_converted_to_lower_case_when_requested is not in camel caps format
|
@pixelpeter This pull request has been sitting here for a bit over a year now. Seems to be a problem for more people than me. Any reason for it not being merged? Thanks! |
sattip
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the webserver only return lowercase headers which leads to an error being thrown when the pagination tries to index the array with headers.
This adds methods to fix this issue.