Fix Windows paths by using URL constructor#86
Open
silverwind wants to merge 1 commit intopiqnt:masterfrom
Open
Fix Windows paths by using URL constructor#86silverwind wants to merge 1 commit intopiqnt:masterfrom
silverwind wants to merge 1 commit intopiqnt:masterfrom
Conversation
The URL constructor seems to correctly handle both Windows and Unix-style paths so should be the preferred way to generate File-URIs. This does require Node.js 10 or greated where the `URL` global was intruduced. Some quick tests demonstrating the output: ```` > String(new URL(`file://c:\\a\\b.svg`)) 'file:///c:/a/b.svg' > String(new URL(`file:///a/b.svg`)) 'file:///a/b.svg' ````
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL constructor seems to correctly handle both Windows and Unix-style paths so should be the preferred way to generate File-URIs. This does require Node.js 10 or greater where the
URLglobal was introduced.Some quick tests demonstrating the output:
Can also confirm this works on Windows and Linux.