Skip to content

Fix BindRemoteStream StreamInfo #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix BindRemoteStream StreamInfo #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a15174e
Fix BindRemoteStream StreamInfo
3DRX Jun 14, 2025
e57a57b
Refactor for better testability
3DRX Jun 15, 2025
e5a9e5a
Add test for configureStreams
3DRX Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions rtpcodec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,26 @@ func codecParametersFuzzySearch(
return RTPCodecParameters{}, codecMatchNone
}

// Given a CodecParameters find the RTX CodecParameters if one exists.
// Given a CodecParameters find the RTX PayloadType.
func findRTXPayloadType(needle PayloadType, haystack []RTPCodecParameters) PayloadType {
rtxParam := findRTXCodecParameters(needle, haystack)
if rtxParam != nil {
return rtxParam.PayloadType
}

return PayloadType(0)
}

// Given a CodecParameters find the RTX CodecParameters if one exists.
func findRTXCodecParameters(needle PayloadType, haystack []RTPCodecParameters) *RTPCodecParameters {
aptStr := fmt.Sprintf("apt=%d", needle)
for _, c := range haystack {
for i, c := range haystack {
if aptStr == c.SDPFmtpLine {
return c.PayloadType
return &haystack[i]
}
}

return PayloadType(0)
return nil
}

// For now, only FlexFEC is supported.
Expand Down
Loading
Loading