Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECN to CCFB metric block string output #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mengelbart
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (7752cd4) to head (7135287).

Files with missing lines Patch % Lines
rfc8888.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   77.70%   77.07%   -0.64%     
==========================================
  Files          22       22              
  Lines        2548     2569      +21     
==========================================
  Hits         1980     1980              
- Misses        472      493      +21     
  Partials       96       96              
Flag Coverage Δ
go 77.07% <0.00%> (-0.64%) ⬇️
wasm 77.07% <0.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeTurki
Copy link
Member

Sorry, the lint upgrade caused a conflict. I can fix it for this branch if you'd like! 🙂
pion/.goassets#220

@mengelbart mengelbart force-pushed the add-ecn-to-ccfb-log branch 2 times, most recently from 99db93f to 37f5819 Compare March 22, 2025 03:23
Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to add //nolint:misspell after every line.

@mengelbart mengelbart force-pushed the add-ecn-to-ccfb-log branch from 37f5819 to 9fa0de4 Compare March 22, 2025 03:55
@mengelbart mengelbart force-pushed the add-ecn-to-ccfb-log branch from 9fa0de4 to 7135287 Compare March 22, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants