Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num_reports usage, see errata 8166 #187

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

mengelbart
Copy link
Contributor

There was an errata about the usage of num_reports, and if I understand it correctly, Pion uses the now outdated interpretation of num_reports. This PR fixes this. I don't know if this will break users. Probably only when they try to interop with clients using the old interpretation (like old versions of Pion).

The errata can be found here:
https://www.rfc-editor.org/errata/eid8166

and the corresponding discussions on the mailing list:
https://mailarchive.ietf.org/arch/msg/avt/jCjC3nk52iW0_NHx64bSx8_nn_E/

The overflowEndSequence test case looks wrong to me. It shouldn't error, but instead, wrap the sequence number around. I added a corresponding test case for that. Seems like a bug in the old implementation?

@mengelbart
Copy link
Contributor Author

Looks like we ran into this before...
a6ba630

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.70%. Comparing base (ec84594) to head (ace5356).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rfc8888.go 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   77.86%   77.70%   -0.17%     
==========================================
  Files          22       22              
  Lines        2553     2548       -5     
==========================================
- Hits         1988     1980       -8     
- Misses        470      472       +2     
- Partials       95       96       +1     
Flag Coverage Δ
go 77.70% <66.66%> (-0.17%) ⬇️
wasm 77.70% <66.66%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aalekseevx aalekseevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior definitely makes more sense.

@mengelbart mengelbart force-pushed the fix-ccfb-packet-format branch from cb030c7 to ace5356 Compare March 19, 2025 03:35
@Sean-Der
Copy link
Member

LGTM! @mengelbart

You don't need to wait for me in the future. I am totally ok with you merging things without me. @aalekseevx knows RTP/RTCP better then me these days :)

@mengelbart mengelbart merged commit 7752cd4 into master Mar 22, 2025
14 of 15 checks passed
@mengelbart mengelbart deleted the fix-ccfb-packet-format branch March 22, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants