Skip to content

fix(ux): spamming cmd + , no longer stack opening settings #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesx0416 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3

Replace settings route when reopening settings

4ec0d32
Select commit
Loading
Failed to load commit list.
Open

fix(ux): spamming cmd + , no longer stack opening settings #2757

Replace settings route when reopening settings
4ec0d32
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded May 19, 2026 in 2m 34s

Approved (click on check for details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Simple UX fix that adds conditional replace: true to prevent browser history from stacking when navigating to settings while already in settings. Low risk, self-contained navigation behavior change.

Notes:
No code owners found in target merge base d1e85c4

View more details on MacroscopeApp