Skip to content

fix(swift-ios): honor the Add project starting directory - #23201

Open
juliusmarminge wants to merge 3663 commits into
t3code/rebuild-mobile-app-swiftfrom
fix/issue-16507
Open

juliusmarminge wants to merge 3663 commits into
t3code/rebuild-mobile-app-swiftfrom
fix/issue-16507

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Problem

On the SwiftUI iOS client, Add project always starts its existing-folder browser and clone destination at ~/, even when the selected environment has Add project starts in set to ~/projects. The server returns the setting correctly; the native client did not decode or use it.

Change

Carry addProjectBaseDirectory from each environment's server settings into the native environment model. Seed the folder browser, existing-folder path, and clone destination from the trimmed setting, falling back to ~/ when absent or blank. Environment switches reseed from the selected environment. Late settings update untouched paths, including after repository lookup, while user edits, navigation, and active clone operations retain their paths.

Scope and approval

Fixes https://git.cafe/pingdotgg/t3code/issues/16507

Triaged bug via the automated issue flow; GitCafe issue #16507. Swift-only fix against t3code/rebuild-mobile-app-swift, under the explicit SwiftUI triage guidance. No server, web, desktop, React Native, authentication, permission, or MCP behavior changes. No merge or auto-land requested.

Verification

  • Real isolated development server on main b5a226e49c: server.getConfig returns the configured /tmp/issue-16507-projects; filesystem.browse of ~/ returns /home/ubuntu, and of the configured directory returns /tmp/issue-16507-projects. Runtime transcript. This verifies the host contract, not native rendering.
  • git diff --check passed; commit formatter hooks passed. Both requested reviewers (GPT-6.1-Sol and Claude Opus 5.5) returned MERGE on final head 7a5fcf45e1.
  • cannot-verify ios-swift: bash apps/swift-ios/Scripts/ci-test.sh fails with missing required command: xcodebuild on this Linux VM. No Swift compilation, executable regression tests, or native before/after recordings were produced. Native-check log.

Evidence status (native rows require Apple-host verification; no substitute web/RN captures):

Row Before After Diff0 DiffT
N0: decode/map and legacy config Unverified Unverified N/A: logic N/A: logic
N1–N2: configured and blank folder paths Missing recording Missing recording Not produced Not produced
N3–N4: clone destination and clone prompt Missing recording Missing recording Not produced Not produced
N5–N6: environment switches and user edits Missing recording Missing recording Not produced Not produced
N7: delayed settings, including repository lookup Missing recording Missing recording Not produced Not produced
N8–N9: entry points, error recovery, New project boundary Missing recording Missing recording Not produced Not produced

Final fixture matrix and proof audit: insufficient native proof, eligible only under the explicit platform exception. The audit pins the first late-config correction; the final commit additionally retries seeding after repository lookup, with the same native proof gap.

Evidence index. Native fixtures and captures remain outstanding for Julius under the Swift platform exception. No visual comparison or claim that nothing else changed is made.

Models: Claude Opus 5.5 and GPT-6.1-Sol, through Claude Agent SDK and Codex in T3 Code.

Fixes #16507

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 22, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The new .pnpmfile.cjs adds a line-level oxlint suppression, which requires human review. The supplied comparison also includes release and deployment changes beyond the Swift fix; its unseen portion has not been certified.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 5.0 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 21.5 KiB — 24.4 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.9 KiB — 24.4 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: f79ce56 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Byntham and others added 26 commits November 9, 2026 14:29
…29018)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29150)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ploads and terminal state (#29164)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#29171)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29287)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…en its run starts (#29601)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…9642)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pen conditions (#29678)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… has one digit (#29851)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…3 ms median) (#30038)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…iveries (#30115)

Co-authored-by: Justin <159104807+Justin24506@users.noreply.github.com>
…n character (#30392)

Co-authored-by: maria-rcks <maria@kuuro.net>
#30812)

Co-authored-by: Geezy <igor.licko@gloryck.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
#33447)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…33449)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…keyboard up (#33456)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…3228)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
binjamshid and others added 28 commits November 10, 2026 23:11
…un claude update (#34176)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tab opens again (#34168)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…only the 2-minute sweep (#33548)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…histories (#25728)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ity trees (#33745)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ing a turn (#33900)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…ents (#22553)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… base's PR (#22861)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…2947)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…31972)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…22755)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…he binding changes (#32494)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ing (#22349)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…status stop re-hashing every file (#21341)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… line (#21897)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Lukas Tomondy <lukas.tomondy@moonpyre.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…lready reset (#22993)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ng (#22839)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…t committed (#19652)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
# Conflicts:
#	AGENTS.md
#	docs/user/permission-modes.md
#	pnpm-lock.yaml
#	scripts/package.json
#	vite.config.ts
Main added extensionStatuses to thread snapshots.

AI-assisted; verified with the tests and tools listed above.
@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.