Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: improve SELinux compatibility #2501

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025

What problem does this PR solve?

  • Improve SELinux compatibility
  • Fix the context of the systemd files after moving them from /tmp to /etc/systemd

This doesn't change the SELinux policy. We could do that later if we want. So no docs changes for now.

Because of this we don't change the tiup cluster check for SELinux.

What is changed and how it works?

Check List

Tests

Tested:

  • Deploy cluster

  • Start/Stop cluster

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 21, 2025 09:41
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025
@dveeden
Copy link
Contributor Author

dveeden commented Jan 21, 2025

/component cluster

@dveeden
Copy link
Contributor Author

dveeden commented Jan 21, 2025

/label component/cluster

Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

@dveeden: The label(s) component/cluster cannot be applied. These labels are supported: help wanted, good first issue.

In response to this:

/label component/cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant