Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Persistently disable THP #2498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
tiup cluster check topology.yaml --apply

And then check /etc/default/grub:

...
GRUB_CMDLINE_LINUX="crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rl-swap rd.lvm.lv=rl/root rd.lvm.lv=rl/swap transparent_hugepage=never"
...

Related changes

Release notes:

TiUP Cluster Check now disables THP persistently

@ti-chi-bot ti-chi-bot bot requested review from breezewish and srstack January 21, 2025 07:09
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.04%. Comparing base (f57aa1d) to head (bd4a8ce).
Report is 1 commits behind head on master.

Current head bd4a8ce differs from pull request most recent head d774fd7

Please upload reports for the commit d774fd7 to get more accurate results.

Files with missing lines Patch % Lines
pkg/cluster/manager/check.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2498      +/-   ##
==========================================
- Coverage   52.11%   52.04%   -0.07%     
==========================================
  Files         335      336       +1     
  Lines       36379    36376       -3     
==========================================
- Hits        18957    18929      -28     
- Misses      15109    15138      +29     
+ Partials     2313     2309       -4     
Flag Coverage Δ
tiup 33.81% <ø> (ø)
unittest 21.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dveeden
Copy link
Contributor Author

dveeden commented Jan 21, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants