Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add integration tests for tiproxy #2371

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 29, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot requested a review from srstack January 29, 2024 02:47
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5811bbb) 55.36% compared to head (0a62110) 52.98%.

❗ Current head 0a62110 differs from pull request most recent head 3ef2893. Consider uploading reports for the commit 3ef2893 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
- Coverage   55.36%   52.98%   -2.38%     
==========================================
  Files         329      329              
  Lines       35020    35020              
==========================================
- Hits        19388    18554     -834     
- Misses      13298    14244     +946     
+ Partials     2334     2222     -112     
Flag Coverage Δ
cluster 42.50% <ø> (-2.24%) ⬇️
dm 18.96% <ø> (-6.55%) ⬇️
tiup 33.60% <ø> (-0.05%) ⬇️
unittest 22.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@xhebox xhebox marked this pull request as ready for review January 29, 2024 05:12
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 29, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 05:35:46.558120539 +0000 UTC m=+1370988.122418258: ☑️ agreed by kaaaaaaang.
  • 2024-01-29 05:36:04.067770888 +0000 UTC m=+1371005.632068593: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-01-29 05:49:31.248238662 +0000 UTC m=+1371812.812536366: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 271d5ea into pingcap:master Jan 29, 2024
18 of 19 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants