Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: skip workload schema hack #12095

Merged
merged 3 commits into from
Mar 19, 2025
Merged

utils: skip workload schema hack #12095

merged 3 commits into from
Mar 19, 2025

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Mar 14, 2025

What problem does this PR solve?

Issue Number: ref #12084

Skip a schema, since updating tifilter dependency involves too much changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Sorry, something went wrong.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2025
xhebox added 2 commits March 19, 2025 12:59
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 19, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hongyunyan,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-19 05:59:38.423684376 +0000 UTC m=+421672.107920456: ☑️ agreed by wk989898.
  • 2025-03-19 06:09:33.701943971 +0000 UTC m=+422267.386180067: ☑️ agreed by hongyunyan.

@xhebox
Copy link
Contributor Author

xhebox commented Mar 19, 2025

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 546b2e8 into pingcap:master Mar 19, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants