Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump parser version for ticdc to ignore workload tables #12083

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Mar 6, 2025

What problem does this PR solve?

Issue Number: close #12084

ref pingcap/tidb#58878, update IsSystemSchema function used in ticdc filter, and ignore all tables under workload_schema.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    use filter-helper
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Mar 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Mar 6, 2025
@sre-bot
Copy link

sre-bot commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Mar 6, 2025
@xhebox xhebox changed the title *: bump parser version for ticdc *: bump parser version for ticdc to ignore workload tables Mar 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

@xhebox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 0f66745 link true /test pull-verify
pull-engine-integration-test 0f66745 link true /test pull-engine-integration-test
pull-cdc-integration-pulsar-test 0f66745 link true /test pull-cdc-integration-pulsar-test
pull-cdc-integration-storage-test 0f66745 link true /test pull-cdc-integration-storage-test
pull-cdc-integration-mysql-test 0f66745 link true /test pull-cdc-integration-mysql-test
pull-cdc-integration-kafka-test 0f66745 link true /test pull-cdc-integration-kafka-test
pull-dm-integration-test 0f66745 link true /test pull-dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/needs-triage-completed first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workloadrepo: update parser to ignore workload tables for ticdc
2 participants