dm: Add marker option to redact info log #12070
Open
+147
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11489
What is changed and how it works?
Add marker option similar to other components(https://docs.pingcap.com/tidb/stable/log-redaction) for redacting info log
Check List
Tests
Manual test with following config to start dm worker:
By testing with a dm task, we can see the related logs:
We are expected to see sensitive data is wrapped by '‹' and '›' marker like other components.
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
Yes, here are a few documentation needed to be updated:
Release note
DM enhances log redaction and supports marking user data in DM worker logs with
‹
and›
. Based on the marked logs, you can decide whether to redact the marked information when displaying the logs, thus increasing the flexibility of log redaction.