Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config AutoSyncInterval to etcd client (#11996) #11999

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11996

What problem does this PR solve?

Issue Number: close #11997

What is changed and how it works?

Add AutoSyncInterval to etcd client which is accidentally removed by #9661

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None.

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jan 14, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@d2b75a2). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.4460% <0.0000%> (?)
dm 51.0428% <0.0000%> (?)
engine 63.4091% <0.0000%> (?)
Flag Coverage Δ
unit 57.2531% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11999   +/-   ##
================================================
  Coverage               ?   57.2531%           
================================================
  Files                  ?        854           
  Lines                  ?     126531           
  Branches               ?          0           
================================================
  Hits                   ?      72443           
  Misses                 ?      48651           
  Partials               ?       5437           

@lidezhu
Copy link
Collaborator

lidezhu commented Jan 14, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 295cb07 into pingcap:release-8.1 Jan 14, 2025
27 checks passed
@lidezhu lidezhu deleted the cherry-pick-11996-to-release-8.1 branch January 14, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants