Skip to content

metrics: add more metrics and improve grafana #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 7 commits into from
Dec 3, 2025
Merged

metrics: add more metrics and improve grafana #3430

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f9b4d3c
add some more metrics
lidezhu Dec 2, 2025
1c1e65e
update grafana
lidezhu Dec 2, 2025
d8558e5
fix
lidezhu Dec 2, 2025
b0d02b6
Apply suggestion from @gemini-code-assist[bot]
lidezhu Dec 2, 2025
116886c
fix
lidezhu Dec 2, 2025
bd2e06e
fix check
lidezhu Dec 2, 2025
ae74735
fix
lidezhu Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions logservice/eventstore/event_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ import (
)

var (
CounterKv = metrics.EventStoreReceivedEventCount.WithLabelValues("kv")
CounterResolved = metrics.EventStoreReceivedEventCount.WithLabelValues("resolved")
kvEventCount = metrics.EventStoreReceivedEventCount.WithLabelValues("kv")
resolvedEventCount = metrics.EventStoreReceivedEventCount.WithLabelValues("resolved")
scannedBytesMetrics = metrics.EventStoreScanBytes.WithLabelValues("scanned")
skippedBytesMetrics = metrics.EventStoreScanBytes.WithLabelValues("skipped")
)
Expand Down Expand Up @@ -612,7 +612,8 @@ func (e *eventStore) RegisterDispatcher(
subscriber.notifyFunc(ts, subStat.maxEventCommitTs.Load())
}
}
CounterResolved.Inc()
resolvedEventCount.Inc()
metrics.EventStoreNotifyDispatcherCount.Add(float64(len(subscribersData.subscribers)))
metrics.EventStoreNotifyDispatcherDurationHist.Observe(float64(time.Since(start).Seconds()))
}
}
Expand Down Expand Up @@ -1147,7 +1148,7 @@ func (e *eventStore) writeEvents(db *pebble.DB, events []eventWithCallback, enco
}
}
}
CounterKv.Add(float64(kvCount))
kvEventCount.Add(float64(kvCount))
metrics.EventStoreWriteBatchEventsCountHist.Observe(float64(kvCount))
metrics.EventStoreWriteBatchSizeHist.Observe(float64(batch.Len()))
metrics.EventStoreWriteBytes.Add(float64(batch.Len()))
Expand Down
Loading