Skip to content

Conversation

@wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref pingcap/tiflow#12424

What is changed and how it works?

According to the comment aws/aws-sdk-go-v2#2370 (comment), we upgrade the dependency and add a test for this error.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 28, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @wk989898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the aws-sdk-go-v2 dependency and its associated modules to their latest versions. The primary motivation for this upgrade is to resolve a specific, identified issue within the AWS SDK, which is further validated by the inclusion of a new test case.

Highlights

  • Dependency Upgrade: The aws-sdk-go-v2 dependency has been upgraded to a newer version, specifically from v1.38.1 to v1.40.0, along with several related AWS SDK modules.
  • Issue Resolution: This upgrade directly addresses a known issue within the aws-sdk-go-v2 library, as referenced in AWS SDK issue stability-test - 2025-09-28 04:00:07 #2370, aiming to resolve potential errors.
  • Test Coverage: A new test has been added to specifically cover the error scenario that this dependency upgrade aims to fix, ensuring the issue does not recur.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the aws-sdk-go-v2 dependencies to resolve an endpoint issue. The dependency updates in go.mod and go.sum are correct.

I have one suggestion to improve the error handling in a related file, which is now more robust with the upgraded SDK.

Additionally, the pull request description mentions adding a test for the fixed error, but it appears to be missing from the changes. Please consider adding the test case to ensure the fix is verified and prevent future regressions.

Comment on lines +17 to +20
github.com/aws/aws-sdk-go-v2 v1.40.0
github.com/aws/aws-sdk-go-v2/config v1.32.2
github.com/aws/aws-sdk-go-v2/credentials v1.19.2
github.com/aws/aws-sdk-go-v2/service/glue v1.134.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With this upgrade of aws-sdk-go-v2, there's an opportunity to improve error handling in pkg/sink/codec/avro/glue_schema_registry.go. Currently, error handling for EntityNotFoundException relies on string matching (e.g., lines 303 and 317). This is fragile and not idiomatic.

The recommended way with aws-sdk-go-v2 is to use type assertion with errors.As. This makes the code more robust against changes in error messages.

For example, you could refactor the error handling in getSchemaByName and getSchemaByID like this:

import (
    "errors"
    "github.com/aws/aws-sdk-go-v2/service/glue/types"
)

// ... in getSchemaByName and getSchemaByID
var e *types.EntityNotFoundException
if errors.As(err, &e) {
    return false, "", nil
}
return false, "", errors.Trace(err)

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 28, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, tenfyzhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,tenfyzhong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-28 06:00:30.226879512 +0000 UTC m=+855393.876073969: ☑️ agreed by tenfyzhong.
  • 2025-12-01 06:17:00.270970079 +0000 UTC m=+244165.084747661: ☑️ agreed by 3AceShowHand.

@wk989898
Copy link
Collaborator Author

wk989898 commented Dec 1, 2025

/retest-required

@wk989898
Copy link
Collaborator Author

wk989898 commented Dec 1, 2025

/retest

assert "ErrDispatcherFailed" in resp.text, f"{resp.text}"

# create changefeed fail because glue schema config is invalid
url = BASE_URL1_V2+"/changefeeds"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be compatible with next-gen mode, please add the parameter keyspace=keyspace1 to the URL.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot merged commit 946ff11 into pingcap:master Dec 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants