wip #3238
wip #3238
Conversation
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test --help |
|
@hongyunyan: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
the
size/M
Summary of ChangesHello @hongyunyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a work-in-progress primarily focused on enhancing the observability of watermark processing within the system. It introduces additional logging in key components responsible for managing and updating watermarks. Additionally, it includes a temporary adjustment to the integration test suite, concentrating on a specific test case, which suggests an ongoing debugging or development effort related to changefeed behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/test pull-cdc-mysql-integration-light |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be a work-in-progress for debugging purposes. It introduces several temporary logging statements across different files, which should be removed before merging to maintain code cleanliness. Additionally, a CI test script has been modified to repeatedly run a single test case, effectively disabling a large suite of integration tests. This change is critical to revert to ensure the CI process remains effective for all developers. My review focuses on pointing out these temporary changes.
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G09 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G10 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G11 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G04 | ||
| 'multi_capture ci_collation_compatibility resourcecontrol fail_over_ddl_E' | ||
| # G05 | ||
| 'vector simple partition_table fail_over_ddl_F' | ||
| # G06 | ||
| 'http_api http_api_tls fail_over_ddl_G synced_status' | ||
| # G07 | ||
| 'http_api_tls_with_user_auth fail_over_ddl_H changefeed_update_config synced_status_with_redo' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G09 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G10 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G11 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G08 | ||
| 'capture_session_done_during_task changefeed_dup_error_restart mysql_sink_retry fail_over_ddl_I' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G09 | ||
| 'cdc_server_tips ddl_sequence server_config_compatibility fail_over_ddl_J' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G10 | ||
| 'changefeed_error bdr_mode fail_over_ddl_K split_table_check' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G11 | ||
| 'multi_tables_ddl ddl_attributes multi_cdc_cluster fail_over_ddl_L' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G12 | ||
| 'row_format tiflash multi_rocks fail_over_ddl_M' | ||
| # G13 | ||
| 'cli_tls_with_auth cli_with_auth fail_over_ddl_N' | ||
| # G14 | ||
| 'batch_add_table batch_update_to_no_batch fail_over_ddl_O' | ||
| # G15 | ||
| 'split_region changefeed_resume_with_checkpoint_ts autorandom gc_safepoint foreign_key_check ddl_for_split_tables old_arch_compatibility' | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G09 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G10 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' | ||
| # G11 | ||
| 'changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart changefeed_dup_error_restart' |
There was a problem hiding this comment.
The mysql_groups array has been modified to repeatedly run the changefeed_dup_error_restart test case, which disables many other important integration tests. This seems to be a temporary change for debugging. Please ensure this is reverted before merging, as it would break the CI for other developers.
| if watermark != nil { | ||
| message.Watermark.Update(*watermark) | ||
| } | ||
| log.Info("hyy watermark", zap.Any("dispatcerID", id), zap.Any("watermark", watermark)) |
There was a problem hiding this comment.
This log statement appears to be for debugging purposes. Please remove it before merging to keep the codebase clean. Also, there's a typo in dispatcerID; it should be dispatcherID.
| }) | ||
| message.Watermark.Seq = seq | ||
| e.latestWatermark.Set(message.Watermark) | ||
| log.Info("hyy whole watermark", zap.Any("watermark", message.Watermark)) |
There was a problem hiding this comment.
This log statement appears to be for debugging purposes. Please remove it before merging to keep the codebase clean.
| old, ok := m.checkpointTsByCapture.Get(msg.From) | ||
| if !ok || req.Watermark.Seq > old.Seq || (req.Watermark.Seq == old.Seq && req.Watermark.CheckpointTs > old.CheckpointTs) { | ||
| m.checkpointTsByCapture.Set(msg.From, *req.Watermark) | ||
| log.Info("hyy onHeartbeatRequest", zap.Any("watermark", *req.Watermark)) |
There was a problem hiding this comment.
This log statement appears to be for debugging purposes. Please remove it before merging to keep the codebase clean.
|
/test pull-cdc-mysql-integration-light |
1 participant
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note