Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: add update action for sysbench schema #1149

Merged
merged 10 commits into from
Mar 25, 2025

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Mar 22, 2025

What problem does this PR solve?

Issue Number: ref #1158

What is changed and how it works?

  1. Support update operation for sysbench workload.
  2. Refactor the workload to make it more readable.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Copy link

ti-chi-bot bot commented Mar 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2025
@asddongmen asddongmen marked this pull request as ready for review March 24, 2025 05:02
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2025
@asddongmen asddongmen self-assigned this Mar 24, 2025
@asddongmen asddongmen marked this pull request as draft March 24, 2025 05:02
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2025
@asddongmen asddongmen marked this pull request as ready for review March 25, 2025 03:38
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Mar 25, 2025
@asddongmen asddongmen requested a review from hongyunyan March 25, 2025 03:58
@asddongmen asddongmen changed the title workload: refactor workload: add update action for sysbench schema Mar 25, 2025
@asddongmen asddongmen added the hold This pull request is not ready to merge. label Mar 25, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 25, 2025
Copy link

ti-chi-bot bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-25 04:03:35.390162415 +0000 UTC m=+933109.074398495: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2025
@ti-chi-bot ti-chi-bot bot merged commit 95a7800 into pingcap:master Mar 25, 2025
10 checks passed
@asddongmen asddongmen removed the hold This pull request is not ready to merge. label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants