Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a PANIC in coordinator. #1107

Merged
merged 25 commits into from
Mar 21, 2025
Merged

Fix a PANIC in coordinator. #1107

merged 25 commits into from
Mar 21, 2025

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Mar 14, 2025

What problem does this PR solve?

Issue Number: close #1140 #1128

What is changed and how it works?

fix the data race problem found in https://github.com/pingcap/ticdc/actions/runs/13850441995/job/38756721999?pr=961

Check List

Tests

  • Integration test
  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 14, 2025
Copy link

ti-chi-bot bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-14 06:53:52.65258443 +0000 UTC m=+511588.258113357: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 14, 2025
@hongyunyan
Copy link
Collaborator Author

/retest

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-heavy

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-heavy

1 similar comment
@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-heavy

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-light

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-heavy

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-light

@hongyunyan
Copy link
Collaborator Author

/test pull-cdc-mysql-integration-heavy

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 20, 2025
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@asddongmen
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2025
@asddongmen
Copy link
Collaborator

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@asddongmen
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit b7d1b2a into pingcap:master Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A PANIC is found in integration test.
2 participants