Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainer: refactor maintainer and controller #1054

Merged
merged 16 commits into from
Mar 4, 2025

Conversation

asddongmen
Copy link
Collaborator

Signed-off-by: dongmen [email protected]

What problem does this PR solve?

Issue Number: ref #1030

What is changed and how it works?

  1. Rename some method in maintainer package.
  2. Replace tsoClient with pdClock to speed up the creation of dispatcher and decrease the PD pressure when creating huge amount of dispatcher.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Copy link

ti-chi-bot bot commented Feb 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2025
Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 03:01:08.589163087 +0000 UTC m=+497616.542321353: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2025
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
@asddongmen asddongmen marked this pull request as ready for review February 27, 2025 09:16
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@asddongmen
Copy link
Collaborator Author

/test all

@asddongmen asddongmen self-assigned this Mar 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit ecd90b4 into pingcap:master Mar 4, 2025
12 checks passed
hongyunyan pushed a commit to hongyunyan/tigate that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants