Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainer: use ticker to generate periodEvent #1031

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

asddongmen
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #1030

What is changed and how it works?

As title.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: dongmen <414110582@qq.com>
Copy link

ti-chi-bot bot commented Feb 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 24, 2025
@asddongmen asddongmen marked this pull request as ready for review February 24, 2025 10:10
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@asddongmen asddongmen self-assigned this Feb 24, 2025
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 24, 2025
Copy link

ti-chi-bot bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 24, 2025
Copy link

ti-chi-bot bot commented Feb 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-24 11:23:06.583788558 +0000 UTC m=+268534.536946842: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot merged commit 0e5af36 into pingcap:master Feb 24, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants